]> dgit.raspbian.org Git - gnome-shell.git/commit
layout: Disconnect 'monitors-changed' handler on shutdown
authorJonas Ådahl <jadahl@gmail.com>
Thu, 2 Feb 2023 14:36:49 +0000 (15:36 +0100)
committerMarge Bot <marge-bot@gnome.org>
Mon, 6 Feb 2023 18:10:01 +0000 (18:10 +0000)
commit7f7ec2a8667cb0fd17fa407c249e2bc242910e17
treeb1dd8dfbf1066fe12bbb4fe76a3e4e10c84b0b50
parent9d75d777c72e4ddc9b05c06f0077484b7002625e
layout: Disconnect 'monitors-changed' handler on shutdown

Doing it ourselves in the shutdown handler in layout.js means we won't
risk reacting to monitor changes that happen after gnome-shell prepares
to shutdown and the signal handler would disconnect itself in case we
used `connectObject(..)`.

This will currently never happen, but in the future perf tests will be
able to create virtual monitors for testing purposes, and they might get
destroyed during the shutdown procedures, causing us to react to them
when we shouldn't.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2623>
js/ui/layout.js